[CXF-4979] WadlGenerator generates invalid xml for QueryParameters with a default value containing " characters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.7
• Fix Version/s: 2.6.8, 2.7.5, 3.0.0-milestone1
• Component/s: JAX-RS

Environment

tomee-1.6.0-SNAPSHOT

• Estimated Complexity: Unknown
• Assignee: Sergey Beryozkin
• Reporter: Antoine Reilles
• Created: 23/Apr/13 11:43
• Updated: 14/Aug/13 15:50
• Resolved: 26/Apr/13 20:22

Description

When defining a service with an @DefaultValue those value contains some double quotes, for instance:

@GET
  public List<Task> tasks(
   @DefaultValue("-\"Created\" -\"Done\"") @QueryParam("states") String states) {
  ...
}

The wadl description generated by the WadlGenerator class is not valid xml: the value should be xml encoded. It seems there are a lot of cases where the inputs are not correctly xml encoded in the generator, @DefaultValue being the one that will most probably contain offending values.

As a side note, WadlGenerator is really painful to extend. For instance, in order to support custom "doc" annotations, one cannot override the handledocs method, but has to redefine all its callers.