[CXF-4429] Incorrect response check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s: 2.6.2, 2.7
• Component/s: JAX-RS Security
• Labels: oauth2
• Estimated Complexity: Novice
• Assignee: Sergey Beryozkin
• Reporter: Jordi Gerona
• Created: 17/Jul/12 13:03
• Updated: 28/Aug/12 17:44
• Resolved: 17/Jul/12 23:03

Description

When an access token response is processed inside OAuthClientUtils class (method getAccessToken), the code checks if the key "OAuthConstants.ERROR_KEY" is present in the returned entity map, but the map's method used is "containsValue()" instead of "containsKey()":

source line:

} else if (400 == response.getStatus() && map.containsValue(OAuthConstants.ERROR_KEY))

{ should be: }

else if (400 == response.getStatus() && map.containsKey(OAuthConstants.ERROR_KEY)) {