[CXF-4134] GZIPOutInterceptor compiles Patterns constantly; they should be compiled once and reused

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.2
• Fix Version/s: 2.3.10, 2.4.7, 2.5.3, 2.6
• Component/s: Core, Transports
• Labels: perfomance

Environment

Any

• Estimated Complexity: Novice
• Assignee: Freeman Yue Fang
• Reporter: Matt Bishop
• Created: 23/Feb/12 23:28
• Updated: 23/Apr/12 16:45
• Resolved: 27/Feb/12 05:06

Description

GZIPOutInterceptor (lines 193 to 195) use two regular expressions to search for a pattern in a string. They compile the regex on every call, and on every pass through a loop:

Pattern zeroQ = Pattern.compile(";\\s*q=0(?:
.0+)?$");
for (String headerLine : acceptEncodingHeader) {
String[] encodings = headerLine.trim().split("[,\\s],
s");

Compiling patterns is not cheap; please move these patterns (including the String.split() pattern) into the constructor or a static member so we don't keep recompiling the pattern.