Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-3693

SecurityTokenServiceProvider does not handle exceptions properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.4.2, 2.5
    • Component/s: None
    • Labels:
      None

      Description

      The SecurityTokenServiceProvider shipped from CXF 2.4 onwards does not handle exceptions properly. There are three issues:

      1) For an exception thrown in an STS implementation, the provider returns a reflection error message as the error String. This is because there is no specific check for an InvocationTargetException.
      2) The exception stacktrace is returned as a Detail, which might reveal internal information to an attacker
      3) There is no way to send back the WS-Trust standard error code/Strings.

      Points 1 and 2 are easily fixed. Point 3 will be fixed by extending the STSException so that a FaultCode (QName) can be set. If it is set on the exception, the standard code/String will be returned, otherwise the error message of the exception will be returned.

        Attachments

          Activity

            People

            • Assignee:
              coheigea Colm O hEigeartaigh
              Reporter:
              coheigea Colm O hEigeartaigh
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: