[CXF-3480] URIMappingInterceptor and ArrayIndexOutOfBounds Error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4
• Fix Version/s: 2.4.1, 2.3.5
• Component/s: Core
• Labels: Interceptors

Environment

Tomcat 6.0.32, CXF 2.4, JDK 1.6.0_23

• Estimated Complexity: Novice
• Assignee: Freeman Yue Fang
• Reporter: Ron Grimes
• Created: 29/Apr/11 17:12
• Updated: 08/Aug/11 14:43
• Resolved: 03/May/11 05:55

Description

URIMappingInterceptor keeps throwing ArrayIndexOutOfBounds error.

Method: getQueries
Statement (318): queries.put(keyValue[0], uriDecode(keyValue[1]));

Proposed Fix
Change from:

        if (!StringUtils.isEmpty(query)) {            
            List<String> parts = Arrays.asList(query.split("&"));
            for (String part : parts) {
                String[] keyValue = part.split("=");
                queries.put(keyValue[0], uriDecode(keyValue[1]));
            }
            return queries;
        }

Change to:

        if (!StringUtils.isEmpty(query)) { 
            List<String> parts = Arrays.asList(query.split("&"));
            for (String part : parts) {
               if (part.contains("=")) {
                   String[] keyValue = part.split("=");
                   queries.put(keyValue[0], uriDecode(keyValue[1]));
               }
            }
            return queries;
        }