[CXF-3433] RPCOutInterceptor naively appends "Response" to the request message name for a response message name

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 2.3.1, 2.3.2, 2.3.3
• Fix Version/s: Invalid
• Component/s: Core
• Labels: RPCOutInterceptor name response

Environment

N/A

• Assignee: Unassigned
• Reporter: Burton Alexander
• Created: 31/Mar/11 08:20
• Updated: 18/Apr/11 12:44
• Resolved: 31/Mar/11 11:21

Description

The existing code in org.apache.cxf.binding.soap.interceptor.RPCOutInterceptor appends "Response" as a suffix to a request message element name for the response name, ignoring the defined name in the associated WSDL. I've implemented the following fix for our environment:

protected String addOperationNode(NSStack nsStack, Message message, XMLStreamWriter xmlWriter, boolean output, BindingOperationInfo boi) throws XMLStreamException {
String ns = boi.getName().getNamespaceURI();
SoapBody body = null;
if (output)

{ body = boi.getOutput().getExtensor(SoapBody.class); }

else

{ body = boi.getInput().getExtensor(SoapBody.class); }

if (body != null && !StringUtils.isEmpty(body.getNamespaceURI()))

{ ns = body.getNamespaceURI(); }

nsStack.add(ns);
String prefix = nsStack.getPrefix(ns);
// Fixes the name problem
String name = getName(boi, output);
StaxUtils.writeStartElement(xmlWriter, prefix, name, ns);
return ns;
}

private String getName(BindingOperationInfo boi, boolean output) {
if (!output)

{ return boi.getName().getLocalPart(); }

return boi.getOutput().getMessageInfo().getName().getLocalPart();
}