[CXF-3360] repeated replace() function calls damage the performance

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.2
• Fix Version/s: 2.4, 2.3.4
• Component/s: Core
• Assignee: Daniel Kulp
• Reporter: Xiaoming Shi
• Created: 23/Feb/11 20:00
• Updated: 18/Apr/11 12:42
• Resolved: 11/Mar/11 04:45

Description

In the function sanitize(String in)

./apache-cxf-2.3.2-src/common/common/src/main/java/org/apache/cxf/management/InstrumentationManager.java line: 307

6 consecutive replace() is called to remove the special characters. It's 5+ times slower than using a for loop replace them all.

e.g.
 - str.replace('a', '#');
 - str.replace('b', '%');

 + StringBuilder sb = new StringBuilder( str.length() );
 + for (int i=0; i < str.length(); i++)
 +  {
 +           char c = str.charAt(i);
 +         if ( c == 'a' )
 +               sb.append('#');
 +       else if ( c== 'b' )
 +               sb.append('%');
 +       else 
 +              sb.append(c); 
 +  }
 +  str  = sb.toString();

This bug has the same problem as the MySQL bug : http://bugs.mysql.com/bug.php?id=45699