[CXF-3214] CXFBusLifeCycleManager will call the preshutdown twice if when the BusApplicationContext is closed

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.10, 2.0.13, 2.2.10, 2.3, 2.2.11, 2.2.12, 2.3.1
• Fix Version/s: 2.3.2, 2.4
• Component/s: Core
• Assignee: Willem Jiang
• Reporter: Willem Jiang
• Created: 22/Dec/10 08:30
• Updated: 16/Jul/13 19:29
• Resolved: 22/Dec/10 13:53

Description

When I write the test of BusApplicationListenerTest I found the BusLifeCycleListener will be called twice when the application context is closed.
The code of CXFBusLifeCycleManager should be changed like this

--- rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java	(revision 1051771)
+++ rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java	(working copy)
@@ -78,9 +78,11 @@
     
     public void preShutdown() {
         // TODO inverse order of registration?
-        preShutdownCalled = true;
-        for (BusLifeCycleListener listener : listeners) {
-            listener.preShutdown();
+        if (!preShutdownCalled) { 
+            preShutdownCalled = true;
+            for (BusLifeCycleListener listener : listeners) {
+                listener.preShutdown();
+            }
         }
     }