[CXF-2711] Concurrency issue with AsyncHandler

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.6
• Fix Version/s: 2.2.7
• Labels: concurrency

Environment

OW2 JOnAS 5.2

• Assignee: Daniel Kulp
• Reporter: Guillaume Sauthier
• Created: 12/Mar/10 16:02
• Updated: 15/Mar/10 13:38
• Resolved: 12/Mar/10 17:41

Description

The problem is on the access to the ClientCallback.done boolean

You can have a situation where the client uses the Future object he got from the dispatch.invokeAsync() method.
It performs an active wait using Future.isDone()

On another Thread, the WS response comes back, and the JaxwsClientCallback.handlerResponse() is called. The handler provided by the client is called, so far everything went well. After the AsyncHandler.handleResponse() invocation, the ClientCallback set the 'done' boolean to true.

But this value change is never seen by the Future.isDone() invocations!

Because the ClientCallback.done boolean is not 'volatile'.

I've made a try with a volatile 'done' and it works perfectly.

Could it be possible that this simple change makes it to the 2.2.7 ?