[CXF-2117] method AnnotationHandlerChainBuilder.patternMatches() causes CXF portability issues with other JAX-WS stacks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.4
• Fix Version/s: 2.1.5, 2.2.1
• Assignee: Daniel Kulp
• Reporter: Richard Opalka
• Created: 17/Mar/09 12:53
• Updated: 15/Oct/09 20:40
• Resolved: 25/Mar/09 02:00

Description

If I have config like this:

<handler-chains xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:ns1="http://org.jboss.ws/jaxws/samples/logicalhandler"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee javaee_web_services_1_2.xsd">

<handler-chain>
<port-name-pattern>ns1:SOAPEndpoint*</port-name-pattern>
<handler>
<handler-name> PortClientHandler </handler-name>
<handler-class> org.jboss.test.ws.jaxws.samples.logicalhandler.PortHandler </handler-class>
</handler>
</handler-chain>

</handler-chains>

the port-name-pattern matches e.g. SOAPEndpointDocPort on JBoss, Glassfish, Websphere but not on Geronimo.
The relevant piece of code is:

private boolean patternMatches(Element el, QName comp) {
...
if (localPart.contains("*"))

{ //wildcard pattern matching return Pattern.matches(localPart, comp.getLocalPart()); // PROBLEMATIC PART HERE }

else if (!localPart.equals(comp.getLocalPart()))

{ return false; }

return true;
}

The problem is:

Pattern.matches("SOAPEndpoint*", "SOAPEndpointDocPort") returns false // CXF expects. SOAPEndpoint.* as wildcard which is not portable cross different APP servers

Consider fix that will match it, please.

Issue Links

• duplicates: CXF-1766 handler chain wildcard matching does not quite work
• is duplicated by: CXF-1345 Support configuring JAX-WS handlers based on port-name-pattern QName
• is related to: CXF-1243 Resolve JBoss common jax-ws testsuite issues