[CXF-1906] Unmarshalling Set to TreeSet instead of HashSet

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.1.3
• Fix Version/s: 2.2
• Component/s: Aegis Databinding
• Estimated Complexity: Moderate
• Assignee: Willem Jiang
• Reporter: Marcus Christie
• Created: 11/Nov/08 15:37
• Updated: 24/Apr/09 21:17
• Resolved: 15/Nov/08 12:58

Description

When using the Aegis databinding, if you are deserializing to a class that has a Set in it, Aegis is currently instantiating the set as a SortedSet. This fails for cases where the objects being added to the set do not implement Comparable, and is undesired in any case.

The error occurs in CollectionType.java:

    protected Collection<Object> createCollection() {
        Collection values = null;

        if (getTypeClass().isAssignableFrom(List.class)) {
            values = new ArrayList();
        } else if (getTypeClass().isAssignableFrom(SortedSet.class)) {
            values = new TreeSet();
        } else if (getTypeClass().isAssignableFrom(Set.class)) {
            values = new HashSet();
        } else if (getTypeClass().isAssignableFrom(Vector.class)) {
            values = new Vector();
        } else if (getTypeClass().isInterface()) {
            values = new ArrayList();
        } else {
....

If the typeClass is Set, then the second "if" clause evaluates to true since Set is a superclass/superinterface of SortedSet.

I've got a patch I'll submit and I'll explain the fix.