[CXF-1819] Make PhaseInterceptorChain.unwind() more defensive wrt handleFault() exceptions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.1
• Fix Version/s: 2.0.10, 2.1.4
• Component/s: Core
• Assignee: Daniel Kulp
• Reporter: Mike Quilleash
• Created: 24/Sep/08 08:42
• Updated: 20/Nov/14 17:03
• Resolved: 23/Jan/09 17:37

Description

Currently the PhaseInterceptorChain.unwind() method looks like this (logging omitted)

while (iterator.hasPrevious())

{ Interceptor currentInterceptor = iterator.previous(); currentInterceptor.handleFault(message); }

It would be better to defend against an exception in handleFault() as currently an exception thrown from a handleFault() stops the unwind.

New proposed code...

while (iterator.hasPrevious()) {
Interceptor currentInterceptor = iterator.previous();
try {
currentInterceptor.handleFault(message);
catch (Exception e)

{ LOG.log( Level.ERROR, "Exception in handleFault on interceptor " + currentInterceptor, e); }

}