[CURATOR-79] InterProcessMutex doesn't clean up after interrupt

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-incubating, 2.1.0-incubating, 2.2.0-incubating, 2.3.0
• Fix Version/s: 2.7.0
• Assignee: Jordan Zimmerman
• Reporter: Orcun Simsek
• Created: 27/Nov/13 03:26
• Updated: 20/Aug/14 21:26
• Resolved: 20/Aug/14 21:26

Description

InterProcessMutex can deadlock if a thread is interrupted during acquire(). Specifically, CreateBuilderImpl.pathInForeground submits a create request to ZooKeeper, and an InterruptedException is thrown after the node is created in ZK but before ZK.create returns. ZK.create propagates a non-KeeperException, so Curator assumes the create has failed, but does not retry, and the node is now orphaned. At some point in the future, the node becomes the next in the acquisition sequence, but is not reclaimed as the ZK session has not expired.

<stack trace attached in comments below>

Curator should catch the InterruptedException and other non-KeeperExceptions, and delete the created node before propagating these exceptions.

(as originally discussed on https://groups.google.com/forum/#!topic/curator-users/9ii5of8SbdQ)