Uploaded image for project: 'Apache Curator'
  1. Apache Curator
  2. CURATOR-675

AsyncStage could stuck from completion due to framework level error listener

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.5.0
    • 5.6.0
    • Framework
    • None

    Description

      AsyncCuratorFrameworkDsl AsyncCuratorFramework.with(UnhandledErrorListener listener) can be used to construct a new framework level object with a global-like error listener. I may be ok for a operation level error listener(e.g. ErrorListenerPathable) to swallow exception from BackgroundCallback but it is too crude to swallow exceptions in global level.

      The call chain is similar to async.with(listener).create().forPath("/foo"). From this, I don't think we are binding an error listener for create() only.

      Besides this, I think it is a good to complete CompletableFuture in all cases.

      Attachments

        Issue Links

          Activity

            People

              kezhuw Kezhu Wang
              kezhuw Kezhu Wang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: