[CURATOR-557] ServiceCacheImpl does not close ExecutorService

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.2.0
• Fix Version/s: TBD
• Component/s: Framework
• Assignee: Unassigned
• Reporter: Roelof Naude
• Created: 22/Jan/20 11:18
• Updated: 28/May/20 23:06

Description

ServiceCacheImpl does not close the ExecutorService instance created from the ThreadFactory:

https://github.com/apache/curator/blob/master/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java#L64

 

CloseableExecutorService::CloseableExecutorService(ExecutorService) call this(executorService, false) which sets shutdownOnClose to false.

 

this has an impact from callers, eg ServiceProviderImpl, which only allow only a ThreadFactory to be specified.

 

 

Issue Links

• links to: GitHub Pull Request #343