Description
CURATOR-505 introduced circuit breaking behavior via CircuitBreakingConnectionStateListener and ConnectionStateListenerDecorator. Elastic has been using it to success but reports that the implementation can be improved. The existing implementation uses a new CircuitBreaker for each ConnectionStateListener set in a Curator client. It turns out that this is not ideal. Instead, a shared CircuitBreaker should be used per Curator client.
Unfortunately, the best way to do this is to remove the ConnectionStateListenerDecorator semantics and use a different mechanism. This Issue proposes to do this and remove ConnectionStateListenerDecorator. This is a breaking change but given the short amount of time it's been in Curator it's unlikely that it's been widely adopted.
If the community considers a breaking change too harsh the older classes can be maintained for a while and marked as @Deprecated.
Attachments
Issue Links
- supercedes
-
CURATOR-505 A circuit breaking ConnectionStateListener would be very helpful
-
- Resolved
-
-
CURATOR-441 Recipes such as TreeCache are susceptible to herding on reconnections
-
- Closed
-
- links to
