[CURATOR-462] InterProcessSemaphoreV2 leaves orphaned lease node if acquiring the semaphore is interrupted at the wrong time

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.11.0, 3.2.0, 3.2.1, 2.11.1, 3.3.0, 2.12.0, 4.0.0, 4.0.1
• Fix Version/s: 4.1.0
• Component/s: Recipes
• Assignee: Unassigned
• Reporter: Gergely Krajcsovszki
• Created: 10/Apr/18 12:03
• Updated: 30/Apr/18 01:53
• Resolved: 30/Apr/18 01:53

Description

Since CURATOR-315, lease nodes created in org.apache.curator.framework.recipes.locks.InterProcessSemaphoreV2.internalAcquire1Lease(Builder<Lease>, long, boolean, long) are not returned if the wait for them to become active is interrupted. This is because the lease node is now only added to the builder at the end of the method, so the caller doesn't know about this node and cannot close it when catching an exception.

We have already fixed this locally in our own dependent library so I'll make a PR with our fix and a test soon. We are still on the 2.x branch so we'd like if this fix could be in 2.13.0.

Issue Links

• is caused by: CURATOR-315 Reconnect during InterProcessSemaphoreV2.acquire can lead to orphaned node
• links to: GitHub Pull Request #263