[CURATOR-41] Curator masks/loses exception in LockInternals

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.6.0
• Component/s: Recipes
• Assignee: Kezhu Wang
• Reporter: Shevek
• Created: 25/Jun/13 22:10
• Updated: 17/Jun/23 13:50
• Resolved: 17/Jun/23 13:50

Description

private boolean internalLockLoop(long startMillis, Long millisToWait, String ourPath) throws Exception

try

{ ... }

catch ( Exception e )

{ doDelete = true; throw e; }

finally
{
if ( doDelete )

{ deleteOurPath(ourPath); }

}

Say ... throws an exception. catch sets doDelete = true. Then deleteOurPath throws an exception. We never find out what the original exception was that caused the mutex to fail.

In JDK8, I think we get the extra Throwable#getSuppressed() call, which will return us this extra exception, but we aren't on JDK8 yet.

Issue Links

• links to: GitHub Pull Request #466