[CURATOR-364] Persistent Node Constructor Requires a Started ZK Connection

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.1, 2.11.1
• Fix Version/s: 3.3.0, 2.12.0
• Component/s: Recipes
• Assignee: Jordan Zimmerman
• Reporter: Ilya Biryukov
• Created: 14/Dec/16 11:07
• Updated: 09/Jan/17 19:26
• Resolved: 09/Jan/17 16:28

Description

Steps to reproduce:
1. Initialise an instance of PersistentNode
2. Ensure that CuratorFramework is Not Started (Latent)

Expected behaviour:
PersistentNode constructor should work without an active CuratorFramework connection to ZK

Actual behaviour:
An Exception is thrown:

Caused by: java.lang.IllegalStateException: instance must be started before calling this methodDEBUG [2016-12-14 10:25:25,641] akka.event.EventStream: logger log1-Slf4jLogger started

	at com.google.common.base.Preconditions.checkState(Preconditions.java:150)
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.create(CuratorFrameworkImpl.java:351)
	at org.apache.curator.framework.recipes.nodes.PersistentNode.<init>(PersistentNode.java:173)

Thoughts
This behaviour is inconsistent with other Zk recepies based on Closable interface. PersistentNode should not attempt any Zk communication until start() method is called.

Issue Links

• links to: GitHub Pull Request #177