[CURATOR-341] create().orSetData() retries indefinitely if node exists

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.2.1
• Component/s: Framework
• Assignee: Unassigned
• Reporter: Henrik Nordvik
• Created: 09/Aug/16 11:12
• Updated: 14/Aug/16 23:35
• Resolved: 14/Aug/16 23:35

Description

Symptom:
One call to create.orSetData().inBackground(callback) writes the data to zookeeper infinitely many times. Version numbers in stat increase quickly. Callback is also called multiple times.

Added the following to TestFramework.testCreateOrSetData() to make it fail:

CuratorEvent event2 = queue.poll(new Timing().milliseconds(), TimeUnit.MILLISECONDS);
Assert.assertNull(event2);

(slows down test, but just to demonstrate it)

Seems like CreateBuilderImpl.backgroundSetData() shouldn't requeue mainOperation after doing setData.

client.queueOperation(mainOperationAndData);

Issue Links

• is related to: CURATOR-268 Curator client doesn't behave well when it loses connection: CRUD operation fail
• links to: GitHub Pull Request #160