Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Recipes
    • Labels:
      None

      Description

      The new dynamic reconfig APIs don't have all permutations and the tests are flakey.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Randgalt opened a pull request:

          https://github.com/apache/curator/pull/108

          CURATOR-265 Dynamic Reconfig APIs needs some work

          • Completely re-wrote the tests
          • The APIs weren't correct for all permutations
          • adding() API was not correct. In ZK, it's called "newMembers" and is mutually exclusive with join/leave

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/curator CURATOR-265

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/curator/pull/108.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #108


          commit 2c0fca86ca3c25c9777e1b5c3bb3eea6cb0be8da
          Author: randgalt <randgalt@apache.org>
          Date: 2015-09-26T00:14:53Z

          interim work - updated APIs make sure old tests work

          commit 4c3c8377935f8ae2c0f24c4a1010cf4bdef4e297
          Author: randgalt <randgalt@apache.org>
          Date: 2015-09-26T00:22:10Z

          Merge branch 'CURATOR-3.0' into CURATOR-265

          Conflicts:
          curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java

          commit d42ef172e57af17ed42d7c2c4e2d9a7a0c520f3c
          Author: randgalt <randgalt@apache.org>
          Date: 2015-09-26T02:07:44Z

          wip - adding() API was misnamed. Also, it's mutually exclusive with join/leave

          commit 36ddd58a31045addfd9d984353956f7a99c09221
          Author: randgalt <randgalt@apache.org>
          Date: 2015-09-26T02:49:12Z

          finalized the changes and removed old classes


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Randgalt opened a pull request: https://github.com/apache/curator/pull/108 CURATOR-265 Dynamic Reconfig APIs needs some work Completely re-wrote the tests The APIs weren't correct for all permutations adding() API was not correct. In ZK, it's called "newMembers" and is mutually exclusive with join/leave You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/curator CURATOR-265 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/curator/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 commit 2c0fca86ca3c25c9777e1b5c3bb3eea6cb0be8da Author: randgalt <randgalt@apache.org> Date: 2015-09-26T00:14:53Z interim work - updated APIs make sure old tests work commit 4c3c8377935f8ae2c0f24c4a1010cf4bdef4e297 Author: randgalt <randgalt@apache.org> Date: 2015-09-26T00:22:10Z Merge branch ' CURATOR-3 .0' into CURATOR-265 Conflicts: curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java commit d42ef172e57af17ed42d7c2c4e2d9a7a0c520f3c Author: randgalt <randgalt@apache.org> Date: 2015-09-26T02:07:44Z wip - adding() API was misnamed. Also, it's mutually exclusive with join/leave commit 36ddd58a31045addfd9d984353956f7a99c09221 Author: randgalt <randgalt@apache.org> Date: 2015-09-26T02:49:12Z finalized the changes and removed old classes
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user iocanel opened a pull request:

          https://github.com/apache/curator/pull/112

          CURATOR-265 Make sure EnsembleTracker only notifies listeners when …

          …the connection string has actually changed. Retry 3 times with a one second interval in TestReconfiguration.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/iocanel/curator curator-265

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/curator/pull/112.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #112


          commit bcb8042a40bab51c6ebaa559ed3c88f3e8b4101b
          Author: Ioannis Canellos <iocanel@gmail.com>
          Date: 2015-10-03T16:59:50Z

          CURATOR-265 Make sure EnsembleTracker only notifies listeners when the connection string has actually changed. Retry 3 times with a one second interval in TestReconfiguration.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user iocanel opened a pull request: https://github.com/apache/curator/pull/112 CURATOR-265 Make sure EnsembleTracker only notifies listeners when … …the connection string has actually changed. Retry 3 times with a one second interval in TestReconfiguration. You can merge this pull request into a Git repository by running: $ git pull https://github.com/iocanel/curator curator-265 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/curator/pull/112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #112 commit bcb8042a40bab51c6ebaa559ed3c88f3e8b4101b Author: Ioannis Canellos <iocanel@gmail.com> Date: 2015-10-03T16:59:50Z CURATOR-265 Make sure EnsembleTracker only notifies listeners when the connection string has actually changed. Retry 3 times with a one second interval in TestReconfiguration.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Randgalt commented on the pull request:

          https://github.com/apache/curator/pull/112#issuecomment-145264544

          Have you seen the changes I made? I made quite a few changes to the config/reconfig APIs.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/112#issuecomment-145264544 Have you seen the changes I made? I made quite a few changes to the config/reconfig APIs.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user iocanel commented on the pull request:

          https://github.com/apache/curator/pull/112#issuecomment-145271348

          I noticed that you made improvements, but I haven't thoroughly looked into them.

          Even with those changes the failure rate for the particular test (TestReconfiguration) is 10%. This PR improves stability dramatically. I stopped testing after I had 100 successful run in a row.

          Show
          githubbot ASF GitHub Bot added a comment - Github user iocanel commented on the pull request: https://github.com/apache/curator/pull/112#issuecomment-145271348 I noticed that you made improvements, but I haven't thoroughly looked into them. Even with those changes the failure rate for the particular test (TestReconfiguration) is 10%. This PR improves stability dramatically. I stopped testing after I had 100 successful run in a row.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/curator/pull/108

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/curator/pull/108

            People

            • Assignee:
              randgalt Jordan Zimmerman
              Reporter:
              randgalt Jordan Zimmerman
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development