[CURATOR-262] Issue with ExponentialBackoffRetry

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.11.0, 3.2.0
• Labels: newbie
• Assignee: Cam McKenzie
• Reporter: Dimitar Dyankov
• Created: 12/Sep/15 20:08
• Updated: 20/Dec/23 04:44
• Resolved: 24/May/16 22:34

Description

Hi,

Looking at the ExponentialBackOff Strategy for the apache curator I found this issue :

@Override
protected int getSleepTimeMs(int retryCount, long elapsedTimeMs)
{
// copied from Hadoop's RetryPolicies.java
int sleepMs = baseSleepTimeMs * Math.max(1, random.nextInt(1 << (retryCount + 1)));
if ( sleepMs > maxSleepMs )

{ log.warn(String.format("Sleep extension too large (%d). Pinning to %d", sleepMs, maxSleepMs)); sleepMs = maxSleepMs; }

return sleepMs;
}

since sleepMs is an Integer and retryCount could be as large as 29 we could fall into an integer overflow case and therefore sleepMs being a negative number.

Issue Links

• links to: GitHub Pull Request #136
• links to: GitHub Pull Request #490