[CURATOR-224] Locking Not Working with DistributedIdQueue

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.9.0
• Component/s: Apache, Framework
• Environment: Windows 7/Java 8
• Assignee: Unassigned
• Reporter: Zhihong Zhang
• Created: 18/Jun/15 21:31
• Updated: 21/Aug/15 18:32
• Resolved: 23/Jun/15 00:09

Description

The locking doesn't work with DistributedIdQeue.

2015-06-18 17:19:47.859 INFO 18244 — [ TaskCache-0] com.pixia.gi.zookeeper.TaskLockingQueue : Path cache event: path=/task_queue/queue-|7qb89wjddu|0000000001, type=CHILD_REMOVED
2015-06-18 17:19:47.864 INFO 18244 — [ TaskCache-0] com.pixia.gi.zookeeper.TaskLockingQueue : Path cache event: path=/task_queue/queue-0000000005, type=CHILD_ADDED

When the DistributedQueue does the requeue, it recreates a new node path without the ID. The bug is in following code block,

if ( requeue )

{ client.inTransaction() .delete().forPath(itemPath) .and() .create().withMode(CreateMode.PERSISTENT_SEQUENTIAL).forPath(makeItemPath(), bytes) .and() .commit(); }

Should replace makeItemPath() with itemPath.

Issue Links

• breaks: CURATOR-231 TestDistributedQueue.testRetryAfterFailure_Curator56 fails