[CURATOR-211] Fix InterProcessReadWriteLock#readLockPredicate() index validation issue

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: awaiting-response
• Fix Version/s: 2.8.0
• Component/s: Recipes
• Labels: easyfix patch
• Environment: All platforms
• Flags: Patch
• External issue URL: https://github.com/apache/curator/pull/75
• Assignee: Jordan Zimmerman
• Reporter: Alexander Makarenko
• Created: 29/Apr/15 22:33
• Updated: 17/Jul/22 06:49
• Resolved: 05/May/15 20:08

Description

Hello, guys! I noticed a small bug in InterProcessReadWriteLock#readLockPredicate() method:

InterProcessReadWriteLock.java, lines 196-211

int         ourIndex = Integer.MAX_VALUE;
for ( String node : children )
{
    if ( node.contains(WRITE_LOCK_NAME) )
    {
        firstWriteIndex = Math.min(index, firstWriteIndex);
    }
    else if ( node.startsWith(sequenceNodeName) )
    {
        ourIndex = index;
        break;
    }

    ++index;
}
StandardLockInternalsDriver.validateOurIndex(sequenceNodeName, ourIndex);

In case if sequenceNodeName is not in children list, StandardLockInternalsDriver.validateOurIndex() won't throw exception, because ourIndex in this case equals to Integer.MAX_VALUE.

I'm creating pull request on Github to fix this issue.

I know it's a very rare case, but why not fix it anyways?

Issue Links

• is duplicated by: CURATOR-307 InterProcessReadWriteLock can throw IndexOutOfBoundsException when connection is lost