[CURATOR-136] Invalid LeaderLatch path never errors

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Component/s: Recipes
• Assignee: Jordan Zimmerman
• Reporter: John Vines
• Created: 07/Aug/14 21:58
• Updated: 06/Nov/14 21:06
• Resolved: 20/Aug/14 21:14

Description

I was messing with the LeaderLatch and I noticed some ill behavior for the pathing of it. Given the following code-

  public static void main(String args[]) throws Exception {
    TestingServer ts = new TestingServer();

    CuratorFramework curator = CuratorFrameworkFactory.builder().connectString(ts.getConnectString()).retryPolicy(new ExponentialBackoffRetry(1000, 5)).build();
    curator.start();
    curator.getZookeeperClient().blockUntilConnectedOrTimedOut();
    curator.create().creatingParentsIfNeeded().forPath("/parent", "A string".getBytes());
    
    try {
      LeaderLatch ll = new LeaderLatch(curator, "parent", "myNode");
      ll.start();
      ll.await();
      System.out.println(ll.hasLeadership());
      ll.close();
    } catch (Exception e) {
      e.printStackTrace();
    }

    ts.close();
  }

the system will just hang forever. Inspecting the TestingServer with zkcli shows entries showing up though.

If I switch out the path in the LeaderLatch constructor with "/parent", the same path is created AND the program runs fine.

LeaderLatch should either accept the path all around or fail outright, not this half state that makes things difficult for the user.