[CURATOR-126] IllegalStateException in performBackgroundOperation during close

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.7.0
• Component/s: Framework
• Assignee: Jordan Zimmerman
• Reporter: Scott Blum
• Created: 24/Jul/14 10:50
• Updated: 29/Jul/14 12:57
• Resolved: 29/Jul/14 00:16

Description

[CuratorFramework-0] ERROR org.apache.curator.framework.imps.CuratorFrameworkImpl  - Background exception was not retry-able or retry gave up
java.lang.IllegalStateException: Client is not started
	at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
	at org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:807)
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.backgroundOperationsLoop(CuratorFrameworkImpl.java:793)
	at org.apache.curator.framework.imps.CuratorFrameworkImpl.access$400(CuratorFrameworkImpl.java:57)
	at org.apache.curator.framework.imps.CuratorFrameworkImpl$4.call(CuratorFrameworkImpl.java:275)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:744)

I see this sometimes during test runs; I believe this happens because CuratorZookeeperClient.started gets set to false during shutdown, but the backgroundOperation loop can still be running since shutting down the backgroundOperation loop is inherently racy.