[CTAKES-299] cannot configure ClearNLPSemanticRoleLabelerAE using XML descriptor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.1
• Fix Version/s: 4.0.0
• Component/s: ctakes-dependency-parser
• Assignee: James Joseph Masanz
• Reporter: Mats Henrikson
• Created: 27/May/14 04:23
• Updated: 14/Mar/17 17:14
• Resolved: 14/Mar/17 17:14

Description

Due to a bug in org.apache.ctakes.dependency.parser.ae.ClearNLPSemanticRoleLabelerAE it is not possible to configure it using an XML descriptor file.

Unfortunately the 3 @ConfigurationParameter fields are configure but never read. For example:

  @ConfigurationParameter(
		  name = PARAM_PARSER_MODEL_FILE_NAME,
		  ...)
  private String parserModelFileName;

The field parserModelFileName is then never read again when trying to load the configured file, instead the field this.srlPredUri is checked:

    	InputStream srlPred = (this.srlPredUri == null)
                ? FileLocator.getAsStream(DEFAULT_PRED_MODEL_FILE_NAME)
                : FileLocator.getAsStream(this.srlPredUri.getPath());

Please change the 3 @ConfigurationParameter annotations to be on the fields that are then used to configure the class (similar to how ClearNLPDependencyParserAE is configured.)