[CTAKES-265] isDuplicate iterates over set

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: ctakes-dictionary-lookup
• Assignee: Unassigned
• Reporter: Tim Miller
• Created: 12/Nov/13 22:36
• Updated: 12/Nov/13 22:37

Description

The private method isDuplicate() in DictionaryLookupAnnotator is used to filter out duplicates from its lookups. It does so by keeping a Set object full of objects its seen before, and then does a lookup by manually iterating over all the elements. I don't see any reason why it shouldn't just call the contains() method of Set, which I do not believe could possibly be slower. Probably much faster in fact. Any thoughts or suggestions?