[CTAKES-241] NullPointerException in ctakes-assertion

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 3.1.0
• Fix Version/s: 3.2.1
• Component/s: ctakes-assertion
• Assignee: Pei Chen
• Reporter: Pei Chen
• Created: 09/Sep/13 14:24
• Updated: 07/Nov/14 17:22
• Resolved: 07/Nov/14 17:22

Description

Assertion module throws an NullPointerException if sentence is null:

I do not full understand ~171, there is a null check, but it doesn't do much other than the log. Subsequently, once it hits, int lineNumber = sentence.getSentenceNumber() + 1, it will throw an NPE.

Should the else{} cover the rest of the method?

org.apache.ctakes.assertion.medfacts.i2b2.api.CharacterOffsetToLineTokenConverterCtakesImpl.convertCharacterOffsetToLineToken(CharacterOffsetToLineTokenConverterCtakesImpl.java:171)

Sentence sentence = findPreviousOrCurrentSentence(characterOffset);
if (sentence == null)

{ logger.info("current or previous sentence IS NULL!"); }

else

{ logger.debug("current or previous sentence -- id: " + sentence.getAddress() + "; begin: " + sentence.getBegin() + "; end: " + sentence.getEnd()); }

int lineNumber = sentence.getSentenceNumber() + 1;