Uploaded image for project: 'cTAKES'
  1. cTAKES
  2. CTAKES-209

Simplify how SentenceDetector models are loaded

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0-incubating
    • Fix Version/s: 3.1.0
    • Component/s: ctakes-core
    • Labels:
      None

      Description

      Sentence Dectector is still using the OpenNLP 1.4 mechanism of loading it's model file.
      a. Suggestion: Let's update it to use the new 1.5 way similar to POSTagger.

      • Remove non longer required classes: SuffixMaxentModelResourceImpl, MaxentModelResource, SuffixSensitiveGISModelReader, classes etc.

      I think this will keep it consistent with the other projects such as POSTagger.
      There may have been a performance reason for shared resources, but this is a tiny model compared to the others, and it's only done once during init time. This should simplify the code and it's references significantly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                chenpei Pei Chen
                Reporter:
                chenpei Pei Chen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: