Commons CSV
  1. Commons CSV
  2. CSV-99

Revert Builder implementation in CSVFormat

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      As discussed on the [1] we want to revert the builder implementation introduced in r1409449 [2].

      [1] http://markmail.org/thread/uohiwcfrbv2kem7l
      [2] http://svn.apache.org/viewvc?view=revision&revision=1409449

        Issue Links

          Activity

          Hide
          Gary Gregory added a comment -

          Patch applied, thank you Benedikt.

          commit -m "[CSV-99] Revert Builder implementation in CSVFormat." (10 paths specified)
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVFormat.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVParser.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVPrinter.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFileParserTest.java
              Deleting       C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFormatTest.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVLexerTest.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVParserTest.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVPrinterTest.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
              Transmitting file data ...
              Committed revision 1508470.
          
          Show
          Gary Gregory added a comment - Patch applied, thank you Benedikt. commit -m "[CSV-99] Revert Builder implementation in CSVFormat." (10 paths specified) Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVFormat.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVParser.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/main/java/org/apache/commons/csv/CSVPrinter.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFileParserTest.java Deleting C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVFormatTest.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVLexerTest.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVParserTest.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/CSVPrinterTest.java Sending C:/vcs/svn/apache/commons/trunks-proper/csv/src/test/java/org/apache/commons/csv/perf/PerformanceTest.java Transmitting file data ... Committed revision 1508470.
          Hide
          Gary Gregory added a comment -

          The patch works, thank you. There are a couple of "toBuilder()" references left to fix in Javadocs. You can apply it AFAIAC.

          Show
          Gary Gregory added a comment - The patch works, thank you. There are a couple of "toBuilder()" references left to fix in Javadocs. You can apply it AFAIAC.
          Hide
          Benedikt Ritter added a comment -

          Hi,

          I've updated my working copy and created a new patch via command line. This should work better than the first one. Thanks for having a look.

          I've tried to make as few changes as possible. For example CSVFormat.copy(CSVFormat) is a substitute for the old CSVFormat.newBuilder(CSVFormat) method, that had to be static because it created a builder. Now that all methods create formats the copy() method could be an instance method.

          Benedikt

          Show
          Benedikt Ritter added a comment - Hi, I've updated my working copy and created a new patch via command line. This should work better than the first one. Thanks for having a look. I've tried to make as few changes as possible. For example CSVFormat.copy(CSVFormat) is a substitute for the old CSVFormat.newBuilder(CSVFormat) method, that had to be static because it created a builder. Now that all methods create formats the copy() method could be an instance method. Benedikt
          Hide
          Benedikt Ritter added a comment -

          D'oh, sorry about that. I'm still getting used to IntelliJ. I'll clean the patch up tonight.

          Show
          Benedikt Ritter added a comment - D'oh, sorry about that. I'm still getting used to IntelliJ. I'll clean the patch up tonight.
          Hide
          Gary Gregory added a comment -

          Hi Benedikt,

          Can you make your match based on the HEAD of trunk please? It does not apply cleanly for me. Also, I tried removing the IDEA lines from the patch but that does not seem to help. Providing a patch without the lines added by IDEA might help.

          Gary

          Show
          Gary Gregory added a comment - Hi Benedikt, Can you make your match based on the HEAD of trunk please? It does not apply cleanly for me. Also, I tried removing the IDEA lines from the patch but that does not seem to help. Providing a patch without the lines added by IDEA might help. Gary
          Hide
          Benedikt Ritter added a comment -

          Initial patch attached

          Show
          Benedikt Ritter added a comment - Initial patch attached

            People

            • Assignee:
              Benedikt Ritter
              Reporter:
              Benedikt Ritter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development