Uploaded image for project: 'Commons CSV'
  1. Commons CSV
  2. CSV-81

Token.Type.isReady could perhaps be removed

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The isReady field is written in lots of places, but only read in 2 places:

      1) CSVParser.getRecord() uses it to determine if there was any data found at EOF
      2) CSVLexer.nextToken uses it to determine when to exit the loop, but could equally probably check for type == INVALID

      It ought to be possible to simplify this considerably since the only usage external to the Lexer is to distinguish the EOF case.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: