Commons CSV
  1. Commons CSV
  2. CSV-34

CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      CSVFormat describes itself as immutable, but it is not @Immutable - the class fields are all mutable.

      The methods that change the fields do so by creating a clone, and returning the changed clone.
      So in a sense the class is immutable.

      However, the normal expectation is that @Immutable classes are @ThreadSafe.
      CSVFormat is not thread-safe, because the fields are not volatile, and the fields are not written & read using a common lock.

      The comment needs to be clarified or removed.

        Activity

          People

          • Assignee:
            Unassigned
            Reporter:
            Sebb
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development