[CSV-302] CSVFormat.duplicateHeaderMode requires default for backward compatibility

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.x
• Component/s: Parser
• Assignee: Unassigned
• Reporter: Markus Spann
• Created: 19/Aug/22 15:42
• Updated: 25/Jan/24 09:45

Description

The member in class CSVFormat

boolean allowDuplicateHeaderNames

 was recently replaced by 

DuplicateHeaderMode duplicateHeaderMode

The boolean defaults to false, while the member of type DuplicateHeaderMode defaults to null.

duplicateHeaderMode must be initialized with DISALLOW for backward compatibility.

The change is also problematic with regards to serialization. The class is serializable and serialVersionUID is unchanged between versions. The boolean setting allowDuplicateHeaderNames in an object serialized in version 1.9.0 or earlier would always be de-serialized to duplicateHeaderMode = null in the current head.

To handle the code changes correctly, customized de-serialization would need to be implemented.

Issue Links

• is related to: CSV-264 Duplicate empty header names are allowed even with `.withAllowDuplicateHeaderNames(false)`
• links to: GitHub Pull Request #276