Commons CSV
  1. Commons CSV
  2. CSV-26

ExtendedBufferedReader does too much

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Component/s: None
    • Labels:
      None

      Description

      There is unnecessary work in ExtendedBufferedReader.

      It offers:

      skip(long)
      skipUntil(char)
      readUntil(char)

      none are ever called. skip(long) is required to fulfill the superclass, but could be stubbed out as it's never called.

      The class is also unnecessarily public for CSV's uses.

      1. SANDBOX-219.patch
        6 kB
        Henri Yandell

        Activity

        Hide
        Jacopo Cappellato added a comment -

        Patch committed in rev. 1065948

        Show
        Jacopo Cappellato added a comment - Patch committed in rev. 1065948
        Hide
        Jacopo Cappellato added a comment -

        Is it ok if I commit Henri's patch?

        Show
        Jacopo Cappellato added a comment - Is it ok if I commit Henri's patch?
        Hide
        Jacopo Cappellato added a comment -

        I have tested this code and it still works well with trunk.

        Show
        Jacopo Cappellato added a comment - I have tested this code and it still works well with trunk.
        Hide
        Henri Yandell added a comment -

        Patch that strips out the unnecessary code. Class has already been made package private.

        Show
        Henri Yandell added a comment - Patch that strips out the unnecessary code. Class has already been made package private.

          People

          • Assignee:
            Unassigned
            Reporter:
            Henri Yandell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development