[CSV-225] Parse method should avoid creating a redundant BufferedReader

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.6
• Component/s: Parser
• External issue URL: https://github.com/apache/commons-csv/pull/28
• External issue ID: 28
• Assignee: Unassigned
• Reporter: Anson Schwabecher
• Created: 19/May/18 06:22
• Updated: 19/May/18 19:33
• Resolved: 19/May/18 16:06

Description

A redundant BufferedReader is created as the inner reader of ExtendedBufferedReader when the CSVParser is created with:

CSVParser#parse(Path, Charset, CSVFormat)

Simply change over from Files#newBufferedReader to Files#newInputStream

 

public static CSVParser parse(final Path path, final Charset charset, final CSVFormat format) throws IOException {

    Assertions.notNull(path, "path");
    Assertions.notNull(format, "format");
    return parse(Files.newInputStream(path), charset, format);
}