Uploaded image for project: 'Commons CSV'
  1. Commons CSV
  2. CSV-214

Adding a placeholder in the Lexer and CSV parser to store the end-of-line string

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5
    • Component/s: Parser
    • Labels:
      None
    • Flags:
      Patch

      Description

      Hi All,
      <My first attempt at adding code to this project>
      In my use-case , I have to read a CSV file, Mangle some columns and then write out a new csv file with those mangled columns.

      I have gone through the parser code and I have found no usable way of getting the line ending information from the CSVParser object. The function readEndOfLine just consumes End of line whether it is CRLF or LF.

      Now that problem is that when I am writing my file back using the CSVPrinter, I need to know what line ending my input file was. I could write an external function to do that. A better way would be to store that information in the CSVParser object and just use it.
      To do that I am just saving the state in a variable and exposing that using a getter.

      I have done some basic testing. and Submitting a pull request regarding that.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ggregory Gary D. Gregory
                Reporter:
                nmahendru Nitin Mahendru
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Remaining Estimate - 24h
                  24h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified