[CRYPTO-141] Errors in native code can leave Java wrappers in bad state

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: Native
• Assignee: Marcelo Masiero Vanzin
• Reporter: Marcelo Masiero Vanzin
• Created: 26/Sep/18 00:11
• Updated: 05/Oct/18 16:38
• Resolved: 05/Oct/18 16:38

Description

Currently, the Java side keeps a reference to the address of the EVP context, and checks that it's not 0 before performing any operations.

But if an error happens in native code, for example here in init():

  if (result == 0 && context != NULL) {
    if (CONTEXT(ctx) != NULL) {
      dlsym_EVP_CIPHER_CTX_cleanup(context);
    } else {
      dlsym_EVP_CIPHER_CTX_free(context);
    }
  }

The address known to the Java side will now be invalid, and if any native method is now called the JVM will crash.