[CRYPTO-13] The API differences between apache.commons.crypto and JCE

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Cipher
• Assignee: Xianda Ke
• Reporter: Xianda Ke
• Created: 22/Apr/16 08:08
• Updated: 28/Apr/16 06:52
• Resolved: 28/Apr/16 06:52

Description

Now, the API of CryptoInputStream & CryptoOutputStream are slightly different from JCE.
In JCE, the cipher must be fully initialized before being used by a CipherInputStream

// Jce API sample
Cipher c= Cipher.getInstance("AES/GCM/NoPadding", "SunJCE");
c.init(Cipher.DECRYPT_MODE, key, new GCMParameterSpec(128, iv));
CipherInputStream cin = new CipherInputStream (InputStream is, Cipher c );

Now, we do the initialization of cipher in the ctor of CryptoInputStream.

//apache.commons.crypto API:
CryptoInputStream(CipherTransformation transformation,  Properties props, InputStream in, byte[] key, byte[] iv)

We should add an interface with two parameters like JCE. This interface would be convenient to support other mode in future such as GCM.
And, Keeping the same API as JCE would more friendly to users.