[CRUNCH-71] PType mapping functions are not initialized before being used for deep copying

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3.0
• Fix Version/s: 0.4.0
• Assignee: Gabriel Reid
• Reporter: Gabriel Reid
• Created: 20/Sep/12 12:26
• Updated: 16/Nov/12 20:06
• Resolved: 20/Sep/12 18:27

Description

The PType#getDetachedValue method performs a deep copy (if needed) in order to allow DoFns to hold on to values that have been passed through them (for example, in join functions).

The WritablePType class uses the built-in input and output MapFns in the PType to handle this deep copying, but the input and output MapFns don't get initialized (i.e. initialize isn't called on them) after they are deserialized along with the DoFn that is using them. In some rare cases (at least for tuples), this can result in NullPointerExceptions or other nastiness.