[CRUNCH-641] Wrong decimal format in dot files

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.15.0, 1.0.0
• Fix Version/s: 1.0.0
• Component/s: Core
• Assignee: Gergő Pásztor
• Reporter: Gergő Pásztor
• Created: 30/Mar/17 14:51
• Updated: 20/Nov/19 14:19
• Resolved: 12/Apr/17 14:19

Description

Failed tests: testFormatPCollectionNodeDeclaration(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...[label="collection 0[.]49 Mb" shape=box];> but was:<...[label="collection 0[,]49 Mb" shape=box];>
testFormatPCollectionNodeDeclaration_InputPCollection(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...rce" [label="input 1[,]729 Mb" shape=folder...> but was:<...rce" [label="input 1[ ]729 Mb" shape=folder...>
testFormatPGroupedTableImplDeclarationAutomatic(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...35802" [label="GBK 1[,]729 Mb (10 Automatic...> but was:<...35802" [label="GBK 1[ ]729 Mb (10 Automatic...>
testFormatPGroupedTableImplDeclarationManual(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...[label="collection 1[,]729 Mb (50 Manual re...> but was:<...[label="collection 1[ ]729 Mb (50 Manual re...>

Java is using the computer's settings to setup the locale and after using this settings to format a number in the dot files. It's not a big problem, because probably only has effect on developers machines, but we should fix it.

Issue Links

• is related to: CRUNCH-519 Plan dot file can display more information