Uploaded image for project: 'Crunch'
  1. Crunch
  2. CRUNCH-641

Wrong decimal format in dot files

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.15.0, 1.0.0
    • Fix Version/s: None
    • Component/s: Core
    • Labels:
      None

      Description

      Failed tests: testFormatPCollectionNodeDeclaration(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...[label="collection 0[.]49 Mb" shape=box];> but was:<...[label="collection 0[,]49 Mb" shape=box];>
      testFormatPCollectionNodeDeclaration_InputPCollection(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...rce" [label="input 1[,]729 Mb" shape=folder...> but was:<...rce" [label="input 1[ ]729 Mb" shape=folder...>
      testFormatPGroupedTableImplDeclarationAutomatic(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...35802" [label="GBK 1[,]729 Mb (10 Automatic...> but was:<...35802" [label="GBK 1[ ]729 Mb (10 Automatic...>
      testFormatPGroupedTableImplDeclarationManual(org.apache.crunch.impl.mr.plan.DotfileWriterTest): expected:<...[label="collection 1[,]729 Mb (50 Manual re...> but was:<...[label="collection 1[ ]729 Mb (50 Manual re...>

      Java is using the computer's settings to setup the locale and after using this settings to format a number in the dot files. It's not a big problem, because probably only has effect on developers machines, but we should fix it.

        Attachments

        1. CRUNCH-641_v1.patch
          1 kB
          Gergő Pásztor

          Issue Links

            Activity

              People

              • Assignee:
                pairg Gergő Pásztor
                Reporter:
                pairg Gergő Pásztor
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: