Uploaded image for project: 'Crunch'
  1. Crunch
  2. CRUNCH-446

Add null checks for DoFn fields

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.4, 0.11.0
    • Component/s: None
    • Labels:
      None

      Description

      DoFn.getConfiguration() gracefully handles the fields being null, but most other methods do not. Adding null checks around all field access within DoFn would make it easier for consumers to write tests for their own function classes because they would not be required to set the context, for instance.

        Attachments

        1. CRUNCH-446.2.patch
          8 kB
          Allan Shoup
        2. CRUNCH-446.3.patch
          7 kB
          Allan Shoup
        3. CRUNCH-446.patch
          6 kB
          Allan Shoup

          Activity

            People

            • Assignee:
              jwills Josh Wills
              Reporter:
              aj987 Allan Shoup
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: