[COUCHDB-884] Improve error handling in couch_rep_reader

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.1
• Component/s: Replication
• Assignee: Filipe David Borba Manana
• Reporter: Filipe David Borba Manana
• Created: 10/Sep/10 14:25
• Updated: 13/Sep/10 11:03
• Resolved: 13/Sep/10 11:03

Description

Currently, the replicator might crash when trying to read a doc from a remote DB. This is due unmatched clauses in a function. Example:

• • Last message in was {'DOWN',#Ref<0.0.0.687>,process,<0.216.0>,
    {function_clause,
    [{couch_rep_reader,'open_doc_revs/3-fun-1',
    [
    Unknown macro: {[{<<"error">>,<<"unauthorized">>}, {<<"reason">>,<<"Authentication required.">>}]}

    ,

The following patch avoids that the replicator crashes in this case and adds a useful error log message as well.

Is anyone against applying this to trunk and 1.0.x? Adam?