CouchDB
  1. CouchDB
  2. COUCHDB-833

Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Futon
    • Labels:
      None
    • Skill Level:
      Regular Contributors Level (Easy to Medium)

      Description

      The current implementation by Paj is slow and pollutes the global namespace with variables and functions. This implementation only exports the SHA1 module and also happens to be up to 3 times faster as an added bonus. See http://bit.ly/9wjjRG for benchmarks.

      1. better_js_sha1.patch
        21 kB
        Devin Torres
      2. better_js_sha1.patch
        22 kB
        Devin Torres

        Activity

        Devin Torres created issue -
        Devin Torres made changes -
        Field Original Value New Value
        Attachment better_js_sha1.patch [ 12450234 ]
        Devin Torres made changes -
        Attachment better_js_sha1.patch [ 12450496 ]
        Paul Joseph Davis made changes -
        Skill Level Regular Contributors Level (Easy to Medium)

          People

          • Assignee:
            Unassigned
            Reporter:
            Devin Torres
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 1m
              1m
              Remaining:
              Remaining Estimate - 1m
              1m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development