Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: None
    • Labels:
      None

      Description

      It turns out to be impossible to trap the exit message from the parent
      process, which is the only reason couch_file traps exits in the first
      place (i.e, this has never worked).

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rnewson opened a pull request:

          https://github.com/apache/couchdb-couch/pull/219

          Don't trap exits in couch_file

          It turns out to be impossible to trap the exit message from the parent
          process in a gen_server, which is the only reason couch_file traps
          exits in the first place (i.e, this has never worked).

          This commit also changes the hot upgrade code to handle this
          transition (but not the previous one).

          COUCHDB-3259

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/cloudant/couchdb-couch 3259-couch-file-trap-exit

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/couchdb-couch/pull/219.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #219


          commit bbc32e160562fc2f6233b6f583cdef28ced8ed9f
          Author: Robert Newson <rnewson@apache.org>
          Date: 2016-12-20T22:32:44Z

          Don't trap exits in couch_file

          It turns out to be impossible to trap the exit message from the parent
          process in a gen_server, which is the only reason couch_file traps
          exits in the first place (i.e, this has never worked).

          This commit also changes the hot upgrade code to handle this
          transition (but not the previous one).

          COUCHDB-3259


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rnewson opened a pull request: https://github.com/apache/couchdb-couch/pull/219 Don't trap exits in couch_file It turns out to be impossible to trap the exit message from the parent process in a gen_server, which is the only reason couch_file traps exits in the first place (i.e, this has never worked). This commit also changes the hot upgrade code to handle this transition (but not the previous one). COUCHDB-3259 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch 3259-couch-file-trap-exit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #219 commit bbc32e160562fc2f6233b6f583cdef28ced8ed9f Author: Robert Newson <rnewson@apache.org> Date: 2016-12-20T22:32:44Z Don't trap exits in couch_file It turns out to be impossible to trap the exit message from the parent process in a gen_server, which is the only reason couch_file traps exits in the first place (i.e, this has never worked). This commit also changes the hot upgrade code to handle this transition (but not the previous one). COUCHDB-3259
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbc32e160562fc2f6233b6f583cdef28ced8ed9f in couchdb-couch's branch refs/heads/master from Robert Newson
          [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=bbc32e1 ]

          Don't trap exits in couch_file

          It turns out to be impossible to trap the exit message from the parent
          process in a gen_server, which is the only reason couch_file traps
          exits in the first place (i.e, this has never worked).

          This commit also changes the hot upgrade code to handle this
          transition (but not the previous one).

          COUCHDB-3259

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbc32e160562fc2f6233b6f583cdef28ced8ed9f in couchdb-couch's branch refs/heads/master from Robert Newson [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=bbc32e1 ] Don't trap exits in couch_file It turns out to be impossible to trap the exit message from the parent process in a gen_server, which is the only reason couch_file traps exits in the first place (i.e, this has never worked). This commit also changes the hot upgrade code to handle this transition (but not the previous one). COUCHDB-3259
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/couchdb-couch/pull/219

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/219
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user eiri opened a pull request:

          https://github.com/apache/couchdb-couch/pull/220

          Fix couchdb_views tests

          Previous commit made couch_file to monitor db_pid instead of linking to it, so number of `monitored_by` for couch_db process, checked in `couchdb_views_tests`, changed.

          COUCHDB-3259

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/cloudant/couchdb-couch fix-views_tests

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/couchdb-couch/pull/220.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #220


          commit 7a5a1a9732abaaa47b90b090c17c72c161e0bad0
          Author: Eric Avdey <eiri@eiri.ca>
          Date: 2017-01-05T21:30:00Z

          Fix couchdb_views tests

          Previous commit made couch_file to monitor db_pid
          instead of linking ot it, so number of monitored_by
          for couch_db process, checked in couchdb_views_tests,
          changed.

          COUCHDB-3259


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user eiri opened a pull request: https://github.com/apache/couchdb-couch/pull/220 Fix couchdb_views tests Previous commit made couch_file to monitor db_pid instead of linking to it, so number of `monitored_by` for couch_db process, checked in `couchdb_views_tests`, changed. COUCHDB-3259 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch fix-views_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #220 commit 7a5a1a9732abaaa47b90b090c17c72c161e0bad0 Author: Eric Avdey <eiri@eiri.ca> Date: 2017-01-05T21:30:00Z Fix couchdb_views tests Previous commit made couch_file to monitor db_pid instead of linking ot it, so number of monitored_by for couch_db process, checked in couchdb_views_tests, changed. COUCHDB-3259
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2994cded4968fa3fbf9f6178c224f3b1f62f3ea5 in couchdb-couch's branch refs/heads/master from Eric Avdey
          [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=2994cde ]

          Fix couchdb_views tests

          Previous commit made couch_file to monitor db_pid
          instead of linking ot it, so number of monitored_by
          for couch_db process, checked in couchdb_views_tests,
          changed.

          COUCHDB-3259

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2994cded4968fa3fbf9f6178c224f3b1f62f3ea5 in couchdb-couch's branch refs/heads/master from Eric Avdey [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=2994cde ] Fix couchdb_views tests Previous commit made couch_file to monitor db_pid instead of linking ot it, so number of monitored_by for couch_db process, checked in couchdb_views_tests, changed. COUCHDB-3259
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/couchdb-couch/pull/220

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/220

            People

            • Assignee:
              Unassigned
              Reporter:
              rnewson Robert Newson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development