Uploaded image for project: 'CouchDB'
  1. CouchDB
  2. COUCHDB-3199

Replicator VDU function doesn't acount for an already malformed document in replicator db

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In case when code is updated from an older version of couchdb which didn't have (or had a less restrictive) VDU function. A malformed document could have ended up in the _replicator database.

      Replicator will try to parse it and flag it as an error then try to update the document. However the more restrictive VDU function will cause the document update to crash the replicator manager.

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 48996b108c458421c8a73097be152769bdc3fc48 in couchdb-couch-replicator's branch refs/heads/couchdb-3199 from Nick Vatamaniuc
          [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=48996b1 ]

          Let "error" replication document updates bypass the VDU function.

          This is necessary in the case where an software upgrade happens with
          a more restrictive VDU function. Replicator db might end up having documents
          which would not pass validation anymore, leading to a replicator manager
          crash when it updates the document with an "error" state.

          So in case of an "error" state allow malformed document so the user can
          see the error.

          COUCHDB-3199

          Show
          jira-bot ASF subversion and git services added a comment - Commit 48996b108c458421c8a73097be152769bdc3fc48 in couchdb-couch-replicator's branch refs/heads/couchdb-3199 from Nick Vatamaniuc [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=48996b1 ] Let "error" replication document updates bypass the VDU function. This is necessary in the case where an software upgrade happens with a more restrictive VDU function. Replicator db might end up having documents which would not pass validation anymore, leading to a replicator manager crash when it updates the document with an "error" state. So in case of an "error" state allow malformed document so the user can see the error. COUCHDB-3199
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nickva opened a pull request:

          https://github.com/apache/couchdb-couch-replicator/pull/50

          Let "error" replication document updates bypass the VDU function.

          This is necessary in the case where an software upgrade happens with
          a more restrictive VDU function. Replicator db might end up having documents
          which would not pass validation anymore, leading to a replicator manager
          crash when it updates the document with an "error" state.

          So in case of an "error" state allow malformed document so the user can
          see the error.

          COUCHDB-3199

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-3199

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/couchdb-couch-replicator/pull/50.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #50


          commit 48996b108c458421c8a73097be152769bdc3fc48
          Author: Nick Vatamaniuc <vatamane@apache.org>
          Date: 2016-10-14T19:13:47Z

          Let "error" replication document updates bypass the VDU function.

          This is necessary in the case where an software upgrade happens with
          a more restrictive VDU function. Replicator db might end up having documents
          which would not pass validation anymore, leading to a replicator manager
          crash when it updates the document with an "error" state.

          So in case of an "error" state allow malformed document so the user can
          see the error.

          COUCHDB-3199


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/50 Let "error" replication document updates bypass the VDU function. This is necessary in the case where an software upgrade happens with a more restrictive VDU function. Replicator db might end up having documents which would not pass validation anymore, leading to a replicator manager crash when it updates the document with an "error" state. So in case of an "error" state allow malformed document so the user can see the error. COUCHDB-3199 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-replicator couchdb-3199 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch-replicator/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit 48996b108c458421c8a73097be152769bdc3fc48 Author: Nick Vatamaniuc <vatamane@apache.org> Date: 2016-10-14T19:13:47Z Let "error" replication document updates bypass the VDU function. This is necessary in the case where an software upgrade happens with a more restrictive VDU function. Replicator db might end up having documents which would not pass validation anymore, leading to a replicator manager crash when it updates the document with an "error" state. So in case of an "error" state allow malformed document so the user can see the error. COUCHDB-3199
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 48996b108c458421c8a73097be152769bdc3fc48 in couchdb-couch-replicator's branch refs/heads/master from Nick Vatamaniuc
          [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=48996b1 ]

          Let "error" replication document updates bypass the VDU function.

          This is necessary in the case where an software upgrade happens with
          a more restrictive VDU function. Replicator db might end up having documents
          which would not pass validation anymore, leading to a replicator manager
          crash when it updates the document with an "error" state.

          So in case of an "error" state allow malformed document so the user can
          see the error.

          COUCHDB-3199

          Show
          jira-bot ASF subversion and git services added a comment - Commit 48996b108c458421c8a73097be152769bdc3fc48 in couchdb-couch-replicator's branch refs/heads/master from Nick Vatamaniuc [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=48996b1 ] Let "error" replication document updates bypass the VDU function. This is necessary in the case where an software upgrade happens with a more restrictive VDU function. Replicator db might end up having documents which would not pass validation anymore, leading to a replicator manager crash when it updates the document with an "error" state. So in case of an "error" state allow malformed document so the user can see the error. COUCHDB-3199
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/couchdb-couch-replicator/pull/50

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/50
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7096273aac92afcffdb326ec963205583b4bc46f in couchdb's branch refs/heads/master from Nick Vatamaniuc
          [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=7096273 ]

          Bump replicator to fix restrictive VDU function issue

          COUCHDB-3199

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7096273aac92afcffdb326ec963205583b4bc46f in couchdb's branch refs/heads/master from Nick Vatamaniuc [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=7096273 ] Bump replicator to fix restrictive VDU function issue COUCHDB-3199

            People

            • Assignee:
              Unassigned
              Reporter:
              vatamane Nick Vatamaniuc
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development