Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: Build System
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Requires patching configure.ac as usual, as major_version will change, and no doubt other things too.

        Activity

        Hide
        dch Dave Cottlehuber added a comment -

        branch at asf/2200-feature-support-erlang-17.0
        https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=refs/heads/2200-feature-support-erlang-17.0

        Generally where-ever we check for early-ish OTP releases like R13B04 or R14B03 (all NIF support related), we need to accommodate the new '17' format instead of R14 or similar. This should stay within configure.ac.

        While the branch compiles & passes tests on OSX with OTP 17.0rc2, I still haven't gotten the configure.ac test working right for the older R* formats. Feel free to push a better solution.

        Show
        dch Dave Cottlehuber added a comment - branch at asf/2200-feature-support-erlang-17.0 https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=refs/heads/2200-feature-support-erlang-17.0 Generally where-ever we check for early-ish OTP releases like R13B04 or R14B03 (all NIF support related), we need to accommodate the new '17' format instead of R14 or similar. This should stay within configure.ac. While the branch compiles & passes tests on OSX with OTP 17.0rc2, I still haven't gotten the configure.ac test working right for the older R* formats. Feel free to push a better solution.
        Hide
        benoitc Benoit Chesneau added a comment -

        imo we should rather focus on the new erlang build. there is no real reason to support r17 for the current couchdb product.

        Show
        benoitc Benoit Chesneau added a comment - imo we should rather focus on the new erlang build. there is no real reason to support r17 for the current couchdb product.
        Hide
        dch Dave Cottlehuber added a comment -
        • because I need r17 support for another project I'm working on
        • because as soon as r17 is released, for better or worse, all the arch, gentoo, and bleeding edge folk won't have a working couch
        Show
        dch Dave Cottlehuber added a comment - because I need r17 support for another project I'm working on because as soon as r17 is released, for better or worse, all the arch, gentoo, and bleeding edge folk won't have a working couch
        Hide
        benoitc Benoit Chesneau added a comment -

        In the mean time, nobody has reviewed the rebar build, so of course, we will need to stick with the current build.... Anyway fair enough.

        Show
        benoitc Benoit Chesneau added a comment - In the mean time, nobody has reviewed the rebar build, so of course, we will need to stick with the current build.... Anyway fair enough.
        Hide
        myers Myers Carpenter added a comment -

        This would be useful for myself. I'm attempting to upgrade the erlang Formula in Mac Hombrew to use 17.0, and couchdb not supporting 17.0 is a blocker.

        Show
        myers Myers Carpenter added a comment - This would be useful for myself. I'm attempting to upgrade the erlang Formula in Mac Hombrew to use 17.0, and couchdb not supporting 17.0 is a blocker.
        Hide
        kxepal Alexander Shorin added a comment -

        Just updated Erlang to 17.0 on Gentoo (it's already available for this OS for week or two as like as for Debian repos) and applied Dave's patch. All tests passed without additional changes.

        Show
        kxepal Alexander Shorin added a comment - Just updated Erlang to 17.0 on Gentoo (it's already available for this OS for week or two as like as for Debian repos) and applied Dave's patch. All tests passed without additional changes.
        Hide
        rnewson Robert Newson added a comment -

        +1 to merge, not that you need it under our committer rules.

        Show
        rnewson Robert Newson added a comment - +1 to merge, not that you need it under our committer rules.
        Hide
        rnewson Robert Newson added a comment -

        To be clear, I was speaking to Dave in my last comment.

        Show
        rnewson Robert Newson added a comment - To be clear, I was speaking to Dave in my last comment.
        Hide
        dch Dave Cottlehuber added a comment -

        thanks Alexander Shorin for gentoo update. Unfortunately my hack doesn't work for older erlang versions, so we can't merge it just yet. I've not gotten the incantations right for both just yet.

        Show
        dch Dave Cottlehuber added a comment - thanks Alexander Shorin for gentoo update. Unfortunately my hack doesn't work for older erlang versions, so we can't merge it just yet. I've not gotten the incantations right for both just yet.
        Hide
        kxepal Alexander Shorin added a comment -

        Dave Cottlehuber it works, I ran the tests on Gentoo and FreeBSD against R14, R15 and R16. One moment is about comparison warnings: I left the note on GH about
        https://github.com/apache/couchdb/commit/505267380373c58f6712f9658ec68c105aad5721#diff-67e997bcfdac55191033d57a16d1408aL440

        Show
        kxepal Alexander Shorin added a comment - Dave Cottlehuber it works, I ran the tests on Gentoo and FreeBSD against R14, R15 and R16. One moment is about comparison warnings: I left the note on GH about https://github.com/apache/couchdb/commit/505267380373c58f6712f9658ec68c105aad5721#diff-67e997bcfdac55191033d57a16d1408aL440
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 296de8b1fe69e66d649294fd0445449b18c49194 in couchdb's branch refs/heads/master from Dave Cottlehuber
        [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=296de8b ]

        Merge branch 'refs/heads/2200-feature-support-erlang-17.0'

        • refs/heads/2200-feature-support-erlang-17.0:
          docs: update supported Erlang/OTP and SpiderMonkey versions
          build: detect new erlang version format correctly
        Show
        jira-bot ASF subversion and git services added a comment - Commit 296de8b1fe69e66d649294fd0445449b18c49194 in couchdb's branch refs/heads/master from Dave Cottlehuber [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=296de8b ] Merge branch 'refs/heads/2200-feature-support-erlang-17.0' closes COUCHDB-2200 refs/heads/2200-feature-support-erlang-17.0: docs: update supported Erlang/OTP and SpiderMonkey versions build: detect new erlang version format correctly

          People

          • Assignee:
            dch Dave Cottlehuber
            Reporter:
            dch Dave Cottlehuber
          • Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development