Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: Replication
    • Labels:
      None

      Activity

      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 7cd0c4f1f7090b3f196a8ec0cbe343359f2edb9a in couchdb-couch-replicator's branch refs/heads/1843-feature-bigcouch from Robert Newson
      [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=7cd0c4f ]

      Support SOCKS5 protocol for replication

      Using "socks5" as the protocol in the "proxy" parameter of replication
      requests will cause DNS resolution and data transfer to happen via a
      SOCKS5 proxy server.

      COUCHDB-2025

      Show
      jira-bot ASF subversion and git services added a comment - Commit 7cd0c4f1f7090b3f196a8ec0cbe343359f2edb9a in couchdb-couch-replicator's branch refs/heads/1843-feature-bigcouch from Robert Newson [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=7cd0c4f ] Support SOCKS5 protocol for replication Using "socks5" as the protocol in the "proxy" parameter of replication requests will cause DNS resolution and data transfer to happen via a SOCKS5 proxy server. COUCHDB-2025
      Hide
      rnewson Robert Newson added a comment -

      You already responded to the original PR with useful feedback, and were not blocking. I only filed this ticket for tracking purposes.

      I agree on the stuff about upstream but I don't have the time to take it on and I don't think that should prevent us moving on with new CouchDB features just because they are best implemented inside our ibrowse subdirectory. I've noted elsewhere that that socks5 support in upstream ibrowse is not good enough.

      Show
      rnewson Robert Newson added a comment - You already responded to the original PR with useful feedback, and were not blocking. I only filed this ticket for tracking purposes. I agree on the stuff about upstream but I don't have the time to take it on and I don't think that should prevent us moving on with new CouchDB features just because they are best implemented inside our ibrowse subdirectory. I've noted elsewhere that that socks5 support in upstream ibrowse is not good enough.
      Hide
      benoitc Benoit Chesneau added a comment - - edited

      I don't see the point of opening a ticket and closing it 36 mn later without giving any chance to someone to review it, or ask for enhancement. Even the PR was available for a really short time. If we open a ticket or a PR then we should let more times to other to react on it except on obvious changes of course.

      Anyway about that change did you contact upstream to see if he was interested by such change? Im we should always contact upstream first to see if he's interested by such change and eventually put it upstream first. There are some reasons for that:

      • we don't have to maintain a fork and porting latest changes from upstream since we are using the same version
      • we help the project to improve and by extent live
      • It can only be good for the couchdb ecosystem

      This is really true in that case since ibrowse has already a minimal support of socks5 (like I said on irc when the topic was discussed). So the author will probably accept any improvement.

      Anyway just a talk. I'm +1 for such feature.

      Show
      benoitc Benoit Chesneau added a comment - - edited I don't see the point of opening a ticket and closing it 36 mn later without giving any chance to someone to review it, or ask for enhancement. Even the PR was available for a really short time. If we open a ticket or a PR then we should let more times to other to react on it except on obvious changes of course. Anyway about that change did you contact upstream to see if he was interested by such change? Im we should always contact upstream first to see if he's interested by such change and eventually put it upstream first. There are some reasons for that: we don't have to maintain a fork and porting latest changes from upstream since we are using the same version we help the project to improve and by extent live It can only be good for the couchdb ecosystem This is really true in that case since ibrowse has already a minimal support of socks5 (like I said on irc when the topic was discussed). So the author will probably accept any improvement. Anyway just a talk. I'm +1 for such feature.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 9dd093df4577a889cd6ef2bb8fb6dfdd2f0381cb in branch refs/heads/master from Robert Newson
      [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=9dd093d ]

      Mention SOCKS5 protocol option in docs

      COUCHDB-2025

      Show
      jira-bot ASF subversion and git services added a comment - Commit 9dd093df4577a889cd6ef2bb8fb6dfdd2f0381cb in branch refs/heads/master from Robert Newson [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=9dd093d ] Mention SOCKS5 protocol option in docs COUCHDB-2025
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit fcd76c9cd4b115165a9904d2894741222f3a575c in branch refs/heads/master from Robert Newson
      [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=fcd76c9 ]

      Support SOCKS5 protocol for replication

      Using "socks5" as the protocol in the "proxy" parameter of replication
      requests will cause DNS resolution and data transfer to happen via a
      SOCKS5 proxy server.

      COUCHDB-2025

      Show
      jira-bot ASF subversion and git services added a comment - Commit fcd76c9cd4b115165a9904d2894741222f3a575c in branch refs/heads/master from Robert Newson [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=fcd76c9 ] Support SOCKS5 protocol for replication Using "socks5" as the protocol in the "proxy" parameter of replication requests will cause DNS resolution and data transfer to happen via a SOCKS5 proxy server. COUCHDB-2025

        People

        • Assignee:
          Unassigned
          Reporter:
          rnewson Robert Newson
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development