Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Futon
    • Labels:
      None
    • Skill Level:
      New Contributors Level (Easy)

      Description

      Fix the opacity on the favicon so it doesnt look awkward on non white browser chrome

      1. bjw_1133.patch
        6 kB
        Benjamin Anderson
      2. favicon.ico
        1 kB
        Benjamin Anderson
      3. favicon.png
        1 kB
        Benjamin Anderson

        Activity

        Dale Harvey created issue -
        Hide
        mikeal added a comment -

        i did this a while back for Futon2. You can see the latest versions in ben's branch:

        https://github.com/BigBlueHat/couchdb/tree/sammy/share/www

        favicon.ico and favicon.png

        there is also new markup in futon that favors the .png

        Show
        mikeal added a comment - i did this a while back for Futon2. You can see the latest versions in ben's branch: https://github.com/BigBlueHat/couchdb/tree/sammy/share/www favicon.ico and favicon.png there is also new markup in futon that favors the .png
        Hide
        Benjamin Anderson added a comment -

        Attached patch against trunk (and icons). Icons were borrowed from the Futon2 repo at mikeal's link.

        Show
        Benjamin Anderson added a comment - Attached patch against trunk (and icons). Icons were borrowed from the Futon2 repo at mikeal's link.
        Benjamin Anderson made changes -
        Field Original Value New Value
        Attachment bjw_1133.patch [ 12477085 ]
        Attachment favicon.ico [ 12477086 ]
        Attachment favicon.png [ 12477087 ]
        Hide
        Randall Leeds added a comment -

        Okay, clearly this patch has sat here too long for how trivial it is.
        But, I don't understand the .patch file... why are those lines removed, Benjamin?

        Show
        Randall Leeds added a comment - Okay, clearly this patch has sat here too long for how trivial it is. But, I don't understand the .patch file... why are those lines removed, Benjamin?
        Hide
        Benjamin Anderson added a comment -

        Not a clue - I'd forgotten that I did this. The patch looks spurious to me.

        Show
        Benjamin Anderson added a comment - Not a clue - I'd forgotten that I did this. The patch looks spurious to me.
        Hide
        ASF GitHub Bot added a comment -

        GitHub user robertkowalski opened a pull request:

        https://github.com/apache/couchdb/pull/261

        Fix opacity on favicon

        Fixes the opacity on the favicon so it doesnt look awkward on non
        white browser chrome

        Original patch by Benjamin Anderson

        Closes COUCHDB-1133

        Before:
        ![bildschirmfoto 2014-08-11 um 00 17 58](https://cloud.githubusercontent.com/assets/298166/3870741/1f6f4a94-20dc-11e4-8721-d5f5f0bf4080.png)

        After:
        ![bildschirmfoto 2014-08-10 um 22 34 03](https://cloud.githubusercontent.com/assets/298166/3870735/8a9e6ff8-20db-11e4-9836-3602f906e191.png)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/robertkowalski/couchdb 1133-favicon

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/couchdb/pull/261.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #261


        commit db36b1f91e980a7bc3110252f71bfb9678c9ba11
        Author: Robert Kowalski <rok@kowalski.gd>
        Date: 2014-08-10T22:09:11Z

        Fix opacity on favicon

        Fixes the opacity on the favicon so it doesnt look awkward on non
        white browser chrome

        Original patch by Benjamin Anderson

        Closes COUCHDB-1133


        Show
        ASF GitHub Bot added a comment - GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/261 Fix opacity on favicon Fixes the opacity on the favicon so it doesnt look awkward on non white browser chrome Original patch by Benjamin Anderson Closes COUCHDB-1133 — Before: ! [bildschirmfoto 2014-08-11 um 00 17 58] ( https://cloud.githubusercontent.com/assets/298166/3870741/1f6f4a94-20dc-11e4-8721-d5f5f0bf4080.png ) After: ! [bildschirmfoto 2014-08-10 um 22 34 03] ( https://cloud.githubusercontent.com/assets/298166/3870735/8a9e6ff8-20db-11e4-9836-3602f906e191.png ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb 1133-favicon Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/261.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #261 commit db36b1f91e980a7bc3110252f71bfb9678c9ba11 Author: Robert Kowalski <rok@kowalski.gd> Date: 2014-08-10T22:09:11Z Fix opacity on favicon Fixes the opacity on the favicon so it doesnt look awkward on non white browser chrome Original patch by Benjamin Anderson Closes COUCHDB-1133
        Robert Kowalski made changes -
        Assignee Robert Kowalski [ robertkowalski ]
        Robert Kowalski made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 712582007458363b7e00ddee138adfb1403ba204 in couchdb's branch refs/heads/master from Robert Kowalski
        [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=7125820 ]

        Fix opacity on favicon

        Fixes the opacity on the favicon so it doesnt look awkward on non
        white browser chrome

        Original patch by Benjamin Anderson

        Closes COUCHDB-1133

        Show
        ASF subversion and git services added a comment - Commit 712582007458363b7e00ddee138adfb1403ba204 in couchdb's branch refs/heads/master from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=7125820 ] Fix opacity on favicon Fixes the opacity on the favicon so it doesnt look awkward on non white browser chrome Original patch by Benjamin Anderson Closes COUCHDB-1133
        Hide
        ASF subversion and git services added a comment -

        Commit 475591e1960147bbfeacc69fdb05f0914afd4df6 in couchdb's branch refs/heads/master from Robert Kowalski
        [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=475591e ]

        Add Benjamin Anderson for fixing COUCHDB-1133 in #7125820074

        Show
        ASF subversion and git services added a comment - Commit 475591e1960147bbfeacc69fdb05f0914afd4df6 in couchdb's branch refs/heads/master from Robert Kowalski [ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=475591e ] Add Benjamin Anderson for fixing COUCHDB-1133 in #7125820074
        Robert Kowalski made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Robert Kowalski made changes -
        Fix Version/s 2.0.0 [ 12315572 ]
        Hide
        ASF GitHub Bot added a comment -

        Github user robertkowalski closed the pull request at:

        https://github.com/apache/couchdb/pull/261

        Show
        ASF GitHub Bot added a comment - Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/261

          People

          • Assignee:
            Robert Kowalski
            Reporter:
            Dale Harvey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development