[COR-16] Tidy-HTML5 x64 Possible Problems

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Won't Fix
• Fix Version/s: 0.5
• Component/s: DocFormats - platform
• Environment: source
• Assignee: jan iversen
• Reporter: jan iversen
• Created: 19/Dec/14 19:12
• Updated: 19/Jan/15 08:35
• Resolved: 19/Jan/15 08:35

Description

I attempted an x64 Linux build of Corinthia using MSYS2 and gcc. The build died on an LValue error in mappedio.c at line 198:

(DWORD)pli->LowPart = GetFileSize( fp, (DWORD *)&pli->HighPart );

It appears to be a problem with x64 widths and file pointers and maybe the casting is simply wrong too.

The greater confusion I have is that the code that failed is under an

#if _MSC_VER < 1300 /* less than msvc++ 7.0

which is itself under an

#if defined(_WIN32)

and it includes <windows.h> of all things.

That may be an artifact of MSYS2 gcc being configured to produce Windows objects and executables. I will have to check that out by compiling Tidy-HTML5 standalone and doing some other things to determine where those defines came from and whether they are needed.